Added functionality to push daily reminder notification everyday at 1… #3322
Conversation
…2AM urging to fill in expenses ,transactions and incomes;
There was a problem hiding this comment.
Revert this change
There was a problem hiding this comment.
Revert these changes
| } | ||
| //For pushing Notification to the user as a reminder at every 12AM | ||
| // urging to fill in expenses, transactions and incomes | ||
| fun createNotificationChannel(context: Context) { |
There was a problem hiding this comment.
Extract this logic in a separate class and module that lives outside :app. For example, :feature:reminders
| @@ -99,6 +99,10 @@ class RootActivity : AppCompatActivity(), RootScreen { | |||
| setupDatePicker() | |||
| setupTimePicker() | |||
|
|
|||
| createNotificationChannel(this) | |||
There was a problem hiding this comment.
Not all users might want to have reminders, use IvyFeatures to make it a customizable setting that's enabled by default
ILIYANGERMANOV
added
the
requested changes
| if (ActivityCompat.checkSelfPermission( | ||
| context, | ||
| Manifest.permission.POST_NOTIFICATIONS | ||
| ) != PackageManager.PERMISSION_GRANTED |
There was a problem hiding this comment.
The code would simpler if:
- Extract the permission check as a
hasNotificationsPermissionfunction - if (hasNotificationsPermisson()) notify
|
|
||
| val builder = NotificationCompat.Builder(context, "DAILY_REMINDER_CHANNEL_ID") | ||
| .setSmallIcon(R.drawable.ic_launcher-playstore) | ||
| .setContentTitle("EveryDay Reminder") |
There was a problem hiding this comment.
Extract these a string so they can be localized
|
Overall, the implementation looks good and should work but please attach a screen recording testing it |
| val builder = NotificationCompat.Builder(context, "DAILY_REMINDER_CHANNEL_ID") | ||
| .setSmallIcon(R.drawable.ic_launcher-playstore) | ||
| .setContentTitle("EveryDay Reminder") | ||
| .setContentText("Fill in todays expences,transactions and incomes.") |
There was a problem hiding this comment.
Thanks for reviewing @suyash01 🙌
github-actions
bot
added
Stale
…2AM urging to fill in expenses ,transactions and incomes;
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
mainbranch.Screen recording of interacting with your changes:
What's changed?
Describe with a few bullets what's new:
...
...
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues?
Troubleshooting CI failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.